Antoine du Hamel

icon indicating a website link https://aduh95.github.io

icon location UTC+2 icon location Node.js collaborator

Results 948 comments of Antoine du Hamel

Use NOCK_ENV=replay by default

I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality. Is it so bad to have to set the variable manually /...

worker_threads is used by many people,but we can only use SharedArrayBuffer(for shared memory) ,but Buffer is node's first citizen（socket eg）,can you share Buffer to SharedArrayBuffer ?

You mean `node:worker_threads`, right? If all buffers could be shared, the language would not have bothered to come up with a `SharedArrayBuffer` implementation. What you can do is the following:...

worker_threads is used by many people,but we can only use SharedArrayBuffer(for shared memory) ,but Buffer is node's first citizen（socket eg）,can you share Buffer to SharedArrayBuffer ?

> no,you are wrong. copy ArrayBuffer is so expensive I don't know why you say I'm wrong, I don't think I have said anything about copy not being expensive. Like...

lib: fix module print timing when specifier includes `"`

> Fixing this implementation also fixes the `console.time` implementation, so if you want to include a test there too, could be useful. Do you have an example? Naive testing (``node...

v8,tools: expose experimental wasm revectorize feature

> Thanks Marco! Rebased to avoid test failures. I would recommend to not rebase, unless there are conflicts to fix: when you rebase, the PR requires a full CI re-run,...

v8,tools: expose experimental wasm revectorize feature

Landed in b5056be8544345ae4dd53601400240479f99b9a1

fs: acknowledge `signal` option in `filehandle.createReadStream()`

Do we know when was this added? If so, could we add an entry in the YAML list?

deps: update libuv to 1.49.0

Lots of test failures, likely related.

deps: update libuv to 1.49.0

@santigimeno please do not use the `request-ci` label when there's already a run available: https://github.com/nodejs/node/blob/eda98728dae77146a4f0d2b2a0fea49fd4ed14e6/doc/contributing/collaborator-guide.md#L252-L257

test: mark `test-net-write-fully-async-buffer` as flaky

> Something is fishy here. I get no failures if I remove the `common` module. https://github.com/nodejs/node/issues/52964#issuecomment-2106357191 also reported that removing `../common` import would remove the flakiness of a different test...