Antoine du Hamel
Antoine du Hamel
Corepack hardcodes pnpm binary path instead of reading package.json bin field (breaks with pnpm v11)
https://github.com/nodejs/corepack/pull/776 does fix pnpm integration, but it doesn't really address this issue. I think this issue is about should Corepack be more dynamic (and therefore, more susceptible to supply chain...
Tests are not passing, there are conflicts, and the linked issue was closed as resolved. Closing for now, thanks for the PR.
CI is failing, can you take a look?
https://github.com/nodejs/node/blob/aa8c4f3ad82aace6a069ae50b24560783900907a/doc/contributing/pull-requests.md#L540-L547 TL;DR commit messages for follow up commits do not matter, they (the messages, not the diffs) will be discarded upon landing. PR title and description hardly matter for the...
There are some relevant test failures, PTAL
This does not land cleanly on v22.x-staging and would require a manual backport PR if we want it there
Landed in 14f02fc2f7c1ea7989bdfeddfadc14921edd4e25
To clarify, Corepack does support ranges in `devEngines`, but you must pin a specific version in `packageManager` field
I get that, I wonder why those services do not define `COREPACK_ENABLE_STRICT=0` in their env as I agree it doesn't make much sense for them to fail in this case....
FWIW I support the proposal to limit permissions to a single team. For public repos, having Write role is rarely relevant, the only difference I can think is that you...