Antoine du Hamel
Antoine du Hamel
It looks like this PR introduces a flakiness to test.parallel/test-net-server-max-connections on Windows, @RafaelGSS can you look into it? I don't think it should land as is.
If you look at the above CI links, you can see that it's always the same `test-net-server-max-connections` test that fails on `2,win2012r2-COMPILED_BY-vs2019-x86`. Having to spawn 13 Jenkins jobs to get...
@gribnoysup Any chance you can address the test failures in time for Node.js v19.0.0? Semver cutoff is in one month from now.
Maybe a better solution would be to have an option for the loader to have an option to tell which file patten it supports for tests? /cc @nodejs/loaders
Running the test runner on a `.ts` file only makes sense if there's a loader able to understand it, so it's convenient if the loader itself can provide this info....
> > I think probably just allowing an RE or glob of test files then as an argument for `--test` ? > > core doesn't currently support glob and regex...
> > Currently `--test` doesn't take any value right? So we could introduce a semver-minor change saying that now `--test` can take an optional string value that will be interpreted...
> introducing a configuration file for the test runner that will allow just importing glob or any other library to filter tests. This is already possible without work from core,...
Or we could keep the test runner minimalistic, and let user land build on top of it to add more complex missing features.
> if I have to do that crazy process.spawn etc, I'd just use Mocha. Or you could use an npm package that reads a Mocha config and run it with...