Antoine du Hamel

Results 948 comments of Antoine du Hamel

No one is maintaining it, and no one is using it. I could bet money that you won't be bothered by user issues.

Seemingly related failure on Windows: ``` --- duration_ms: 175.001 exitcode: 1 severity: fail stack: |- node:internal/modules/run_main:107 triggerUncaughtException( ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 150 !== 134 at...

/cc @nodejs/platform-windows @nodejs/libuv

`git bisect` points to https://github.com/nodejs/node/pull/54077

@targos yes, 7fab6e8885e3e4efebe8c9ae63a89b3b41530407 is "good" (i.e. it builds and the repro exits without any assert), 64e8646618b71427e75d619027d761bc7edd1e0d is "bad" (i.e. it builds and it exits with the assert), it doesn't build...

I wonder if this is still needed after https://github.com/nodejs/release-keys/pull/36 and its follow up PRs

Looks like a GitHub issue, I don't think there's anything we can do 🤷‍♂️ Both commits seems to have the same diff, so it's probably a non-issue as long as...

> it feels like we should be able to handle these automatically without much trouble. It would require changing how to pick up commits quite a lot though, and would...

> I thought merge commits weren't supported by the Jenkins CI workflows anyway but it looks like it wasn't an issue for that PR Maybe a side effect of having...

On top of migrating to GHA, we should probably also consider migrate to hackmd.io, Google Docs is just not great when it comes to markdown.