Antoine du Hamel
Antoine du Hamel
> The only thing that remains in it is the restriction of who can push and that only restricts the `nodejs-github-bot` account You mean `@nodejs/node-core-utils` team, right? The bot has...
Looking at https://github.com/nodejs/node-core-utils/activity?activity_type=direct_push&actor=nodejs-github-bot, I don't think it will be affected, it never pushes to `main`
I’ve never even heard of git work trees, so that might explain the lack of support – I still haven’t figured out why everyone is using branches on their local...
This doesn't land cleanly on v22.x-staging
It should certainly not add a remote without telling the user, if we're dealing with a security PR, it would be a breach of confidentiality to default to the public...
https://github.com/nodejs/node-core-utils/blob/dfa9c9201366e9f025034cd40cb5ec9a8968dc9e/lib/session.js#L381-L388 The default prompt would suggest `remote-upstream` indeed, so maybe it'd worth suggesting `upstream` instead
It would be worth discussing https://github.com/nodejs/node/issues/61022, as well as #1135
I have concerns about the maintainability of such list, with time goes on and contributors come and go, and/or change their areas of interest, I'd expect the table to quickly...