test_runner: differentiate test types in enqueue dequeue events

[EddieAbbondanzio]

The test:enqueue and test:dequeue events now include a type in details to allow reporters to distinguish if it was a suite or test.

Fixes #51235

[nodejs-github-bot]

Review requested:

• [ ] @nodejs/test_runner

[EddieAbbondanzio]

Sure, I added one.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60673/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60701/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60742/

[EddieAbbondanzio]

This PR seems like it may have stagnated. Is there anything needed to get it merged?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60924/

[pmarchini]

Hey @EddieAbbondanzio, I noticed this PR has been stale since August and some files now have conflicts. Could you please resolve them?

[EddieAbbondanzio]

Hey @pmarchini, I can work on bring it back but do you know why it went stale? Was there something else I needed to do to get it merged after all the approvals it got back in July?

[pmarchini]

Hey @EddieAbbondanzio, honestly, I can't see any reason why this PR should remain stalled. I would suggest fixing the conflicts and then landing it 😊

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.54%. Comparing base (35742a2) to head (214b59e). Report is 244 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54049      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190742   190746       +4     
  Branches    36606    36603       -3     
==========================================
- Hits       168901   168888      -13     
- Misses      15027    15039      +12     
- Partials     6814     6819       +5     

Files with missing lines	Coverage Δ
lib/internal/test_runner/test.js	96.96% <100.00%> (+<0.01%)	:arrow_up:
lib/internal/test_runner/tests_stream.js	91.71% <100.00%> (+0.09%)	:arrow_up:

... and 23 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64289/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64291/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64296/

[EddieAbbondanzio]

Hey @pmarchini, is there anything on my end I need to do to merge this?

I'm still new to contributing to Node and don't have permissions to add the merge-queue label (seems like that's what this PR needs based on the docs) but I'm also not 100% certain why some of the CI jobs are intermittently failing. Appreciate your help!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64308/

[pmarchini]

Hey @EddieAbbondanzio, you can't do anything else on your side atm 😁 We have some problems with flaky tests, and that's the reason why the CI keeps failing. I'm restarting it again now!

As soon as the CI is green, and if @cjihrig and @MoLow are still okay with this change, we will land it 🚀

Thank you very much for your patience and your support to Node 🚀

[nodejs-github-bot]

Landed in 383e1a281b6b979ede9d2ee46781643971da104b

[aduh95]

~test/parallel/test-runner-output.mjs is failing when trying to backport this to v22.x-staging. Please open a backport PR if we want this on v22.x~ actually, it was relatively trivial to fix, nevermind