node icon indicating copy to clipboard operation
node copied to clipboard

lib,test: enforce use of `assert.fail` via a lint rule

Open aduh95 opened this issue 2 weeks ago β€’ 4 comments

assert.fail communicates the intent better than assert(false) IMO

aduh95 avatar Dec 09 '25 11:12 aduh95

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.55%. Comparing base (029ebac) to head (79df8b2). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61004      +/-   ##
==========================================
+ Coverage   88.51%   88.55%   +0.03%     
==========================================
  Files         703      703              
  Lines      208522   208522              
  Branches    40212    40219       +7     
==========================================
+ Hits       184564   184647      +83     
+ Misses      15957    15905      -52     
+ Partials     8001     7970      -31     
Files with missing lines Coverage Ξ”
lib/internal/crypto/cipher.js 97.94% <100.00%> (ΓΈ)

... and 35 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 09 '25 12:12 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70448/

nodejs-github-bot avatar Dec 09 '25 14:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70460/

nodejs-github-bot avatar Dec 09 '25 20:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70462/

nodejs-github-bot avatar Dec 09 '25 22:12 nodejs-github-bot

Landed in 79df8b209b00fd1d4e5343fa036e5c1eb80f43e1

aduh95 avatar Dec 11 '25 14:12 aduh95