Antoine du Hamel comments

Results 948 comments of


                                            Antoine du Hamel

doc: run license-builder

https://github.com/nodejs/node/pull/58721/commits/3a2635055f98456cccde27c11058e4de2ec362c2 looks alright, https://github.com/nodejs/node/pull/58721/commits/fb9541e5f3240704f2e8ce9a347b725af550d1fd not so much. It looks like it's older, maybe just closing this PR and deleting the branch will be enough to get rid of it. EDIT:...

[v22.x backport] esm: implement import.meta.main

We should only pick the commits that have landed on `main`, this PR have 47 commits that are not on `main`

[v22.x backport] esm: implement import.meta.main

> @aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK?...

[v22.x backport] esm: implement import.meta.main

Can you please rebase?

[v22.x backport] esm: implement import.meta.main

Rebased on top of `v22.x`, fixed the commit message

[v22.x backport] esm: implement import.meta.main

Landed in f99aa748c090...2fc89892abaa

test_runner: prefer `Atomics` primordials

Landed in ef2e0848ba36

Error: Cannot find module 'C:\Program Files\nodejs\node_modules\corepack\dist\yarn.js'

> corepack enable // as usual That's not necessary btw, could you try without it?

corepack use does not load COREPACK_NPM_REGISTRY from .corepack.env

Can you please run the command with `DEBUG=corepack` set in your env?

corepack use does not load COREPACK_NPM_REGISTRY from .corepack.env

Yeah it looks like `.corepack.env` is completely ignored when running `corepack use`, looks like an oversight. Any chance you would like to submit a patch for this?