Kevin Eady

Results 125 comments of Kevin Eady

Hi @mylowillem , Are you using `NAPI_EXPERIMENTAL`? If so, please check this comment on a similar issue: https://github.com/nodejs/node/issues/52229#issuecomment-2040131493 If not, please state the same here, and we'll look further.

We discussed this in the 9 Dec 2022 Node-API meeting. @vmoroz will take a look at the possibility of using private symbols in Hermes engine so we can get a...

Created PR in core to add link to Node-API main documentation: https://github.com/nodejs/node/pull/46189

We discussed in the 9 Dec Node-API meeting, @NickNaso has created the documentation on this repo and will create the PR on Node core linking to it next week.

@NickNaso would it be worthwhile to close this issue and create a new one for documenting how to create a new wrapper? I think the scope of this issue is...

@KevinEady to investigate adding a coverage badge to the root README.md.

Next step: Create a "condensed report" which analyzes why some coverage paths are not taken and present this to team for triage.

Hi @markpiffer , Is it possible for you to provide a more in-depth reproduction, preferably in a git repository? A cursory glance at your pasted code shows nothing problematic /...

Closing due to inactivity. If you need further assistance, please let us know.

Hi @gabrielschulhof , Looks like this is becoming of more importance. I can take a look at continuing this work? Judging by the latest CI failure, looks like the `Napi::External`...