Kevin Eady
Kevin Eady
I'd like to discuss the naming of the new define `NAPI_CPP_EXCEPTIONS_ALL` ... to go with convention it should be `NODE_ADDON_API_CPP_EXCEPTIONS_ALL`. We can use `NODE_ADDON_API_CPP_EXCEPTIONS_ALL` and introduce `NODE_ADDON_API_CPP_EXCEPTIONS` as a (backwards-compatible)...
We discuss in the 18 Oct Node-API meeting: - Use the `NODE_ADDON_API_` prefix on the defines - Should the "catch all" be the new default? - What about some best...
Hi @vmoroz @mhdawson @legendecas @gabrielschulhof , I believe this is ready.
Hi @edoCsItahW , > `But I don't want to set descriptors for every attribute` What is the reasoning behind this, as that would determine a solution. If it's because you...
@gabrielschulhof , I really like the qualifier of "basic" for the env. > ... basic conveys the idea that fewer things can be done when you only have a "basic"...
@gabrielschulhof , regarding finalizers: ```cpp void my_sync_finalizer(node_api_basic_env env, void* data, void* hint); void my_regular_finalizer(napi_env env, void* data, void* hint); ``` eg. for documentation, would you say that a finalizer can...
In the 5 July Node-API meeting, we settled on the finalizer accepting a `node_api_basic_env` being called a "basic finalizer" like in the original post: ```c typedef void (*node_api_basic_finalizer)(node_api_basic_env, void* data,...
@legendecas , Should we also update the README.md to set the new version (or remove it completely so we don't have to constantly update it)?
@vmoroz your comment on removing const ref on `std::nullptr_t` has been addressed, and @mhdawson your comment on reference deletion has been addressed, both in [2a689b6](https://github.com/nodejs/node-addon-api/pull/1514/commits/2a689b6bde71b731cb29a2a0b5aec244a2fc59ca)
Hi team, Using some SFINAE magic, I was able to determine at compile time how to associate the finalizer -- either directly or with `node_api_post_finalizer`. This would address #1367 as...