Kevin Eady

Results 125 comments of Kevin Eady

Hi @kelvinhammond , I have not been able to replicate the above error in my own libzim environment. Looking at the code, everythings looks correct: Runtime type-checking ```cpp if (!provider.Get("feed").IsFunction())...

I have been _pulling_ my hair out trying to understand what's going on. In a previous meeting, there was a suggestion that maybe there is some buffer overflow in the...

In the 1 July 2022 Node API meeting, we discussed trying to use the MemorySanitizer and AddressSanitizer feature in Clang to find a possible memory issue. The documentation is here:...

Hi @kelvinhammond , Apologies for the delay. I was on a traveling vacation and should be getting back into the swing of things this weekend. I see that https://github.com/openzim/node-libzim/pull/72 was...

Hi @robinchrist / @mmomtchev / @BB-fat , We discussed this in the 1 July Node API meeting. Do you have a repository that reproduces this issue? Since this is using...

Hi @mmomtchev , That logic does follow. However from what I'm seeing in the code for the [finalize wrappers](https://github.com/nodejs/node-addon-api/blob/main/napi-inl.h#L209-L254), these just call the finalizer with the data and context as...

Hi @robinchrist , In my threadsafe-function `AsyncIterator` example, I call [`Release()`](https://github.com/nodejs/node-addon-examples/blob/89791944a3bb3d664fbc59716b1fca3228594ba1/threadsafe-async-iterator/node-addon-api/example.cc#L128) at the end of the `std::thread`'s entry point.

We discussed this in the 7 Oct Node API meeting. > My theory: Node destroys the TSFNs on Node's side before it frees / destroys the objects of the addon....

I believe this is addressed by the core pr: https://github.com/nodejs/node/pull/36510

Hi @GaurangTandon , Does Michael's suggestion above provide you with any information? Do you need any further assistance?