Kevin Eady

@gabrielschulhof , > For env, we'd have DuringGcEnv and Env, since Env is already established, ... One could argue that being a Node-API wrapper, the naming in this library should...

I've added some WIP documentation on the top-level finalization page: https://github.com/nodejs/node-addon-api/blob/6591a3609c2b94f22956b72736e06b86586556cf/doc/finalization.md

@mhdawson @gabrielschulhof as discussed in the 5 July Node-API meeting, I updated the docs to use the concept of a "basic finalizer" as a special categorization of finalizers, and removing...

@legendecas the overall C++ work/implementation is finished, but the PR still needs some more work (markdown docs, test docs, ...) @mhdawson > 1. I would remove > > NOTE: Optimizations...

In Node API meeting 19 July, we discussed: > 1. I would remove > > NOTE: Optimizations via basic finalizers will only occur if using NAPI_EXPERIMENTAL and the NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT define...

Hi @mhdawson @vmoroz @legendecas @gabrielschulhof , I believe this PR is ready for review now! - Finished renaming "synchronous" finalizer to "basic" finalizer - Updated docs - Removed semver major...

I would like to land https://github.com/nodejs/node-addon-api/pull/1548 and rebase this PR so we can get a Windows + experimental test run.

The Windows experimental CI passed, eg: [test (experimental, 20.x, x64, windows-2019)](https://github.com/nodejs/node-addon-api/actions/runs/10218072154/job/28273303597#step:7:3698) ``` Testing with Node-API Version '2147483647'. ``` @legendecas @mhdawson @gabrielschulhof @vmoroz PTAL! 👍

Hi @gabrielschulhof , IIRC you mentioned you had an in-progress review. Any movement on that?

Hi @legendecas , This PR was merged into main, but the `release-please` action failed: https://github.com/nodejs/node-addon-api/actions/runs/10687066491/job/29623803353 I think it has to do with permissions?