Kevin Eady

Results 125 comments of Kevin Eady

Hi @jerylvaz, Thanks for noticing this. Would you like to submit a PR...?

Hi @legendecas , can you elaborate some more on the problem introduced in 853? Maybe we can discuss in today's call. EDIT: Ah, I see it now: https://github.com/nodejs/node-addon-api/blob/e439222fe64e941dfeeb9d865d05214ab8770a0c/napi-inl.h#L6010-L6013 https://github.com/nodejs/node-addon-api/blob/e439222fe64e941dfeeb9d865d05214ab8770a0c/napi-inl.h#L5999-L6002 https://github.com/nodejs/node-addon-api/blob/e439222fe64e941dfeeb9d865d05214ab8770a0c/napi-inl.h#L5736-L5740...

😅 The above fix might be a bit premature. Let's discuss in the call.

Current state: I have an implementation that solves this issue, but it suffers from the "not all of the async `Signal()` calls (which calls the TSFN `NonBlockingCall()`) get executed. We...

In today's Node API meeting, we discussed the possibility of using the `Proxy` object as a wrapper on the natively `ObjectWrap`'d object. Using this approach, we may be able to...

Hi @kelvinhammond , We discussed this in the 13 May Node API meeting. Is it possible to provide a standalone repository that reproduces this issue? This will help with our...

Hi @kelvinhammond , I will take a look at your example repository and get back to you as soon as possible. Thanks for the quick response! Kevin

Hi @kelvinhammond , Can I ask which Node version you are testing with? Thanks, Kevin

So I tried your makeLargeZim test with a debug version of node 16.15.0 and I can receive one of three different segfaults: ``` # # Fatal error in ../deps/v8/src/handles/global-handles.cc, line...

We discussed in the 10 June Node API meeting to try to make a standalone reproduction of this problem that would be a little easier to debug / troubleshoot. If...