Kevin Eady

Results 125 comments of Kevin Eady

We discussed in the 11 Nov Node API meeting of "where do we put links to videos". We believe the best approach would be something similar to what we plan...

Congrats @vmoroz on getting this PR landed! This has been a long time in the making with several users wanting this type of functionality 😄

Hi @martenrichter , You mentioned a GitHub Actions run. Do you have a repository with this code we can look at?

Hi @martenrichter , I broke your issue down into a simple Node API method: ```cpp Napi::Value Method(const Napi::CallbackInfo &info) { Napi::Env env = info.Env(); double timedelay = 200000; auto val...

Hi @martenrichter , Thanks for the repro code! Using windows-2022 + ClangCL definitely is the trigger for the error. I was able to install the necessary reproduction deps on my...

So I did a little more digging... Adding another piece to the puzzle: It doesn't seem like it's the compiler version, but maybe how it's being invoked within cmake-js or...

Hi @martenrichter, I have been able to compile the native addon with command-line using `cl`, `clang-cl`, and `clang++`. So you are on the right path: using the [delay load import](https://learn.microsoft.com/en-us/cpp/build/reference/delayload-delay-load-import?view=msvc-170)...

Nice find @martenrichter ! I've written a bit on that issue. We'll see if it'll gain any traction. So, I guess you have a few options: 1. Not use the...

FWIW, node-addon-api is restricted to the same build restrictions as node, which is c++17.

I think in instances where functionality is added that is not specifically a wrapper for Node-API functionality, we defer to placing the functionality in a separate module/package owned by the...