Kevin Eady comments

Results 125 comments of


                                            Kevin Eady

Object wrap has a memory leak bug?

@Apidcloud , you should just be be able to define `NAPI_EXPERIMENTAL` and I think it should "just work" in node 21. The default behavior with experimental mode (and soon to...

Object wrap has a memory leak bug?

Hi @audetto , You are correct in that `node-addon-api` does not yet support these nogc finalizers. There is a wip here: https://github.com/nodejs/node-addon-api/pull/1409

Object wrap has a memory leak bug?

Hi @audetto , This came up in the 10 May Node-API meeting. The current WIP linked above fixes compilation in experimental mode by wrapping finalizers in a `node_api_post_finalizer` call. This...

Segmentation faults - Inconsistent errors with lots of async workers and objects

Hi @kelvinhammond , Is this still an issue? I noticed there has been some work after merging the initial branch. I forked the repository and enabled the `test-mem-leak` script in...

Object spread not working with Napi::ObjectWrap

Hi @UrielCh , This is not an issue with node-addon-api and does not need to be "fixed", as it is the way the JavaScript works. ```js class Foo { get...

When to use NODE_API_ADDON() instead of NODE_API_MODULE()?

Since this issue has no work done since Nov 2022, we are closing this issue. If you need more help, please reopen or create a new issue. Thanks!

`const` error with `AsyncProgressWorker<T>::ExecutionProgress::Signal()`

Yep. Closing issue.

(Typed)ThreadSafeFunction.Release() crashes renderer process on reload (& abort?)

We discussed this issue in the 24 Feb Node API team meeting. There is a backing PR (https://github.com/nodejs/node/pull/46692) in core to verify the order as described in https://github.com/nodejs/node/pull/45903. Once the...

AsyncProgressQueueWorker::Signal() does not trigger the TSFN

Fixed by #1216

Electron 21 breaks api compatability with some modules

We discussed this in the 11 Nov Node API meeting. Since https://github.com/nodejs/node/pull/45181 has been merged, there is no additional work for the Node API team regarding this issue. We can...