Kevin Eady

Results 125 comments of Kevin Eady

This is expected behavior. Your `_startListeners` function will create the threads and add a new "request to execute code" via the `NonBlockingCall` at each thread run, but the actual execution...

Hi @GaurangTandon , We discussed in the 18 March Node API meeting: 1. It would be beneficial to update the TSFN documentation to explain the above behavior, in that the...

Hi @lili2012 , `util.inspect` has an additional configuration parameter for `getters`: when set to `true`, getters will be inspected. See [`util.inspect` documentation](https://nodejs.org/dist/latest/docs/api/util.html#util_util_inspect_object_options). Can you add `getters: true` to your `util.inspect`...

Hi @lili2012 , The original issue was only discussing how to enumerate the properties correctly for use with object spread. `console.log` internally uses `util.inspect` on objects to display them. If...

Hi @JckXia , I took a look at this and have a few questions: 1. This tests `TypedThreadSafeFunction`, do we have equivalent coverage for the non-typed `ThreadSafeFunction`...? 2. I looked...

Hi @tak40548798 , Please check the documentation for the [Execute](https://github.com/nodejs/node-addon-api/blob/main/doc/async_worker.md#execute) callback, specifically: > As the method is not running on the main event loop, it must avoid calling any methods...

Hi @ammarfaizi2 , We discussed this on today's Node API meeting. This is a similar issue as found on https://github.com/nodejs/node-addon-api/issues/1140 . We are waiting on some PRs in node core...

Hi @mhdawson , The `AsyncProgress[Queue]Worker::Signal()` method is supposed to call the `OnProgress` worker with `nullptr` for `data` and `0` for `count`. The main change is not using `NonBlockingCall()` but instead...

Hi @nodejs/node-api , This PR introduces two changes: (1) allowing references to all values and (2) the ability for modules to request certain feature sets at module registration. @vmoroz has...

We discussed in the 7 Oct Node API meeting that this PR is dependent on the feature-flags implementation inside #42557. Instead of adding the new methods (in PRs first post),...