Kevin Eady

Results 125 comments of Kevin Eady

Another thing @legendecas , i did not make any changes to `AsyncProgressQueueWorker` regarding a state member like [1f2cd71](https://github.com/nodejs/node-addon-api/pull/1216/commits/1f2cd71a281c393ae7663b3c9513030bf3fe1b5a). Since the queue variety of the progress worker stores all progress updates,...

Hi @SassNinja / anybody else trying to do this... I ended up changing my architecture... Instead of the main script (which calls `run()`) generating the config object, move the object...

I can take a look at this. I am wondering about what we should do with the versioning of our package? Should it match the Node.js version the headers are...

Hi @NickNaso , So I see the (semi-)automated release flow going like so: - Create new workflow (`prepare-release`) that: - triggers only on `main` with changes in `['def/*', 'include/*']` -...

A test run on my local fork created these artifacts: - `prepare-release` [[Run log](https://github.com/KevinEady/node-api-headers/actions/runs/9129248417/job/25103342265)] - Created [PR](https://github.com/KevinEady/node-api-headers/pull/63) to update `package.json` and `CHANGELOG.md` - `publish-release` [[Run log](https://github.com/KevinEady/node-api-headers/actions/runs/9129290492/job/25103492613)] - Ran `npm publish`...

We discussed in the 17 May Node-API meeting that the manual running of `publish-release` is acceptable, and in the future, we can make it automated if we see that we...

I'm moving this back to draft, as the custom release code could be replaced with https://github.com/googleapis/release-please-action similarly to https://github.com/nodejs/node-addon-api/pull/1523.

Closing in favor of #43 , #44

Closing due to inactivity. Please reopen if you need further assistance.

We discussed in the 22 Aug Node-API meeting regarding APIs for promotion. Before promoting any basic env / finalizer changes, we should address https://github.com/nodejs/node/issues/59583