Kevin Eady

Add example that uses NODE_API_ADDON for addon registration

1

It appears that all of our examples use the `NODE_API_MODULE` macro to register native addons. It would be helpful to add an example that uses `NODE_API_ADDON` registration, where the module...

AsyncProgressQueueWorker::Signal() does not trigger the TSFN

8

As reported in https://github.com/nodejs/node-addon-api/pull/1086#issue-1017797535

src: fix implementation of AsyncProgressWorker::Signal

2

Fix implementation of `AsyncProgressWorker::Signal` and `AsyncProgressQueueWorker::Signal` Fixes: #1095 Fixes: #1081

We discussed on the 7 Oct Node API meeting: There have been several PRs that have been merged (or waiting to be merged) that fix behavior of APIs. We should...

ci: add support for automated releases

2

Creates two new jobs, `prepare-release` and `publish-release`, as discussed in https://github.com/nodejs/node-api-headers/issues/13#issuecomment-2100471529. The `publish-release` job requires a CI env secret, `NPM_TOKEN`, as discussed here: [Publishing packages to the npm registry](https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry). The...

src: add support for nogc types via `NogcEnv`

8

- Introduce `Napi::NogcEnv` class, taking the place of `Napi::Env` in finalizer callbacks. - Introduce `void Napi::NogcEnv::AddPostFinalizer()` and overloads. - Modify tests to support above changes TODO: - [ ] docs...

Discussion: Formatting inconsistency in markdown documentation

3

Some documented methods have the C++ definition before the description: https://github.com/nodejs/node-addon-api/blob/b8525e2f8ca8887c5ec864706c27b8872a5a6256/doc/env.md?plain=1#L87-L104 ... while others have the description before the C++ definition: https://github.com/nodejs/node-addon-api/blob/b8525e2f8ca8887c5ec864706c27b8872a5a6256/doc/addon.md?plain=1#L144-L161 For some rough stats, it seems to be...

Improve coverage report with experimental runs

2

The CI job for coverage only runs for files under the `npm test` command. This does not include experimental builds, therefore code coverage reported in pull requests exclude those changes.

`function_reference` test failure when using Debug build of node v20.13.1

1

Using node v20.13.1 built with debug configuration according to [Building: Building a debug build](https://github.com/nodejs/node/blob/main/BUILDING.md#building-a-debug-build) fails: ``` > [email protected] test > /Users/kevineady/Projects/node/out/Debug/node test napiVersion:9 Testing with Node-API Version '9'. Starting test...

Add wrappers for `node_api_nogc_env` and `node_api_nogc_finalize`

8

Since https://github.com/nodejs/node/pull/50060 is now in core, we need to add support for these types. Looking at the Node-API [docs](https://nodejs.org/api/n-api.html), we can find which node-addon-api methods on `Napi::Env` should be split...