klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Provide BL Touch reference for RAMPS board

Open Arelav opened this issue 9 months ago • 5 comments

Provide BL Touch reference for RAMPS board I tested it on my RAMPS v1.4

Arelav avatar Mar 20 '25 21:03 Arelav

Thankyou for submitting a PR,

Please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

JamesH1978 avatar Mar 24 '25 08:03 JamesH1978

Thankyou for submitting a PR,

Please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

Updated commit message but not PR description. Please let me know if something else required.

Arelav avatar Mar 29 '25 00:03 Arelav

@JamesH1978 anything else from my side to make it merged?

Arelav avatar Apr 06 '25 23:04 Arelav

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Apr 30 '25 12:04 github-actions[bot]

@JamesH1978 If you'll have a chance to review the change. Otherwise this issue will close automatically. I won't join Discord to make my PR to be merged.

Arelav avatar May 01 '25 00:05 Arelav

I'm not using the printer I was made a reference for anymore but it could be useful for someone. It's stays waiting review forever. Feel free re-open it if it's useful.

Arelav avatar Sep 12 '25 00:09 Arelav