Peter David Fagan

Results 126 comments of Peter David Fagan
trafficstars

Thanks @sloretz this is an awesome response I appreciate the detail. > It looks like your API [expects an rclcpp::Node::SharedPtr &](https://github.com/peterdavidfagan/moveit2/blob/cb4941d41de679c6e11197c1283e1a6bbc83b567/python/moveit_py/src/moveit_py/example.cpp#L17-L18), but [your example is passing it](https://github.com/peterdavidfagan/moveit2/blob/cb4941d41de679c6e11197c1283e1a6bbc83b567/python/moveit_py/example/example.py#L12) the [Python class...

I am currently revising my implementation for `moveit_py`. During GSoC I went with the approach of initializing and creating a `rclcpp` node in a custom constructor for my class (seen...

Thanks for the detailed overview and links @rhaschke. > Why, instead of wrapping a new Node class for rclpy, you didn't simply wrap the existing rclcpp class? I was reluctant...

> My comment was not targeting you, @peterdavidfagan, but the developers of rclpy. Ah ok my bad and understood.

Hi @knorth55, Thanks for posting this fix. I am looking to build the package for ROS rolling. I haven't looked too closely into this bug but I presume the current...

Thanks for the confirmation on this @knorth55.

The lite6 is also shaking quite a bit for me when I run MoveIt Servo :(.

@MeticulousFishFrier was your code merged?

> @peterdavidfagan you are using ros1 or ros2? Hi @Akumar201 I have been using ROS 2. I am revisiting this now, I still observe shaking. Did you get to resolve...

Hi @kevinzakka, Your repository [dexterity](https://github.com/kevinzakka/dexterity) is really awesome, I've started exploring it recently, it is fun to use and I'm learning quite a bit from your code. Thank you for...