Victor Zverovich
Victor Zverovich
> **double**:https://github.com/xjb714/f2dec_bench/blob/main/main.cpp#L612 `void check_double();` It's nice to test this but I don't think it can qualify as a proof because it only checks a subset of `double`s. An exhaustive test...
The code already includes `fmt/format.h` so including `fmt/core.h` or `fmt/base.h` is redundant - those only provide a subset of the API. I suggest simply removing those includes.
Is it still something you are interested in? I was thinking of adding an NL writer to https://github.com/ampl/mp, which already provides a reusable NL reader (actually two if you count...
BTW the author of yy double to string conversion algorithm did some work on verifying its correctness recently: https://github.com/ibireme/c_numconv_benchmark/blob/master/vendor/yy_double/verify.py
Superseded by https://github.com/facebook/folly/commit/21e8dcd464ee46b2144a1e4d4c0e452355ae15f0 but thanks for working on this!
Please note that erthink is using his projects to spread hate speech so I wouldn't recommend transferring any projects to that user.
`#` is supposed to be used with numeric presentation types and doesn't make much sense with `c`. We could ban it even though it's pretty harmless.
Merged, thank you!
Thanks for the explanation! I guess an easy fix would be to switch back to `floor + 1`. This is what I did in [my implementation](https://github.com/vitaut/schubfach) but I was hoping...