Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

About the -Wstringop-overflow= issues

Thanks for the information. All the known cases of `-Wstringop-overflow=` warnings (false positives) have been fixed but if you see more please provide a repro.

About the -Wstringop-overflow= issues

Please provide a godbolt repro.

About the -Wstringop-overflow= issues

Thanks, reopening.

About the -Wstringop-overflow= issues

Worked around in https://github.com/fmtlib/fmt/commit/a16ff5787b104945f735b1a2250b85c441a1af8e (ignore the commit message - it was accidentally messed up 🤦).

ERROR: format.cc.o is of type `CXX_MODULES` but does not provide a module interface unit or partition

Could you provide a self-contained repro illustrating what you are trying to do and the problem? Also check out https://vitaut.net/posts/2023/simple-cxx20-modules/.

ERROR: format.cc.o is of type `CXX_MODULES` but does not provide a module interface unit or partition

I mean without any external projects, just the minimal code snippet and build commands. We are not going to debug your CMake configs.

join couldn't be found an appropriate overload when fmt is imported as a module.

Looks like this overload of `join` is currently not marked as exported: https://github.com/fmtlib/fmt/blob/02537548f3a9efb5f3b83755acf50c8a16ba58c8/include/fmt/ranges.h#L700 A PR to fix it would be welcome.

several -Wconversion and/or -Wsign-conversion warnings on MINGW when formatting std::chrono::system_clock::now()

Could you provide a godbolt repro?

several -Wconversion and/or -Wsign-conversion warnings on MINGW when formatting std::chrono::system_clock::now()

> I have now tried and succeeded to reproduce a very similar set of warnings under ubuntu 24.04 gcc13.3 OK, these are sufficient repro details, we don't need godbolt.

A faster double to string algorithm

Thanks for sharing. Do I understand correctly that you are the author of this implementation? I would recommend adding it to https://github.com/fmtlib/dtoa-benchmark first so that it can be compared to...