Victor Zverovich

Results 199 comments of Victor Zverovich

@jdrouhard, if you want to override the standard range formatter you also have to opt out of it being formatted as a range or use an adapter type. `is_range` cannot...

Fixed in #3964 (thanks to @Arghnews).

@wey-gu, sorry for slow reply. I wonder why is this not covered by the `fcntl is None` check above?

Can we make it more generic with something like hasattr instead of checking the platform?

fbthrift doesn't provide build configs for transport libraries at the moment which is one of the reasons that `example_server` is not part of the build.

There is no CMake config for the `example_server` so you cannot build it with CMake.

Are you sure that `is_std_string_like::value` returns true? AFAICS `QString` doesn't have `find_first_of` (https://doc.qt.io/qt-6/qstring.html) which is used as a `std::string[_view]` detection heuristic.

Thanks for reporting. The problem is that the wrong format context is being used in the nested `format` call. We'll need to tweak the API a bit to synchronize contexts.

> Would this be acceptable? I'd recommend using SFINAE instead of conditional compilation if possible. > Also I ran clang-format-18 -i --style=file include/fmt/ranges.h like suggested and still have the formatting...