Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

Warnings thrown by Coverity static analyses

I added a test for the full exponent range and unsurprisingly the last warnings also turned out to be false positives.

Error when formatting `_BitInt`

I was not aware of `_BitInt` working in version 9, it was entirely accidental. We should make it work intentionally and add a test case.

Error when formatting `_BitInt`

_BitInt support has been added by @Arghnews (thanks!) in #4072.

GCC 14 optimizer doesn't like std::filesystem::path formatting (Wstringop-overflow)

It does look like false positive so might be worth reporting to gcc but I applied a workaround in https://github.com/fmtlib/fmt/commit/0379bf3a5d52d8542aec1874677c9df5ff9ba5f9.

GCC 14 optimizer doesn't like std::filesystem::path formatting (Wstringop-overflow)

> The same warning happens if write_escaped_cp is always inlined. If you have a better solution, a PR would be welcome.

Cannot suppress range formatter when type has a container_type member type.

Could you elaborate why you want to disable the container adaptor formatter?

Add support for _BitInt on clang

@Arghnews, do you plan to update this PR or shall we close it for now (can be reopened later)?

Add support for _BitInt on clang

No hurry. Let's keep it open and enjoy your holiday!

Add support for _BitInt on clang

Merged, thanks!

Difference in performance between the default and explicit presentation specifiers in format string compilation

The default format is more optimized in the format string compilation. In general it doesn't make sense to use redundant specifiers but we could handle them in the same way...