Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

new fmt dependency reduces usability of folly

> Are any combinations of folly/fmt supposed to be compatible? Folly is compatible with fmt 7.x. > is this tested? Yes. > Is there a way to make the fmt...

new fmt dependency reduces usability of folly

fmt 8.0.1: https://github.com/facebook/folly/blob/93c44c56cda1c57e48fb42c30aff55acf2436814/build/fbcode_builder/manifests/fmt#L5

Add coroutine support / lazyass streaming

Yes

Support strftime `-` extension

I don't see `%-I` documented in https://man7.org/linux/man-pages/man3/strftime.3.html. Is it some kind of an extension?

Support strftime `-` extension

{fmt} supports only standard specifiers at the moment but a PR to add `-` would be welcome.

Support strftime `-` extension

There is no IRC, we usually discuss such issues on github.

Tests fail using NVIDIA HPC compilers (PGI compilers)

Please post the actual test failures.

Tests fail using NVIDIA HPC compilers (PGI compilers)

Closing as it is clearly a compiler bug (please report to NVIDIA). A PR with a workaround would be welcome provided that it's not too intrusive.

Tests fail using NVIDIA HPC compilers (PGI compilers)

Reopening to track test failures.

Failing tests on MSYS2/MinGW x64

IIRC `std::locale` is broken in MinGW so I don't think we can do much about the first issue other than disabling the test (a PR would be welcome). Not sure...