Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

Add support for alternative month format

`%OB` seems non-standard: https://eel.is/c++draft/tab:time.format.spec. Where is it documented?

Add support for alternative month format

Closing as there doesn't seem to be much interest but a PR would still be welcome.

Warning using Clang-17

Could you submit a PR?

Update checks for dynamic_cast usage when compiled with no rtti

Could you provide a godbolt repro for the ostream issue?

Update checks for dynamic_cast usage when compiled with no rtti

Merged, thanks.

formatter simply inheriting from built-in formatter is not recognised

Right now the `string_view` formatter only accepts `string_view` and not objects convertible to it but I think it's reasonable to relax this.

the GITHUB_TOKEN does not have write permission when running `lint.yml` workflow

Workflows already have read and write permissions: ![image](https://github.com/fmtlib/fmt/assets/576385/a01c4cb9-b6c3-4f1d-98c5-6312d53567cc) so I'm not sure why they are reported as read-only in the log.

the GITHUB_TOKEN does not have write permission when running `lint.yml` workflow

I could create a custom token although it's weird that the default one is not working.

the GITHUB_TOKEN does not have write permission when running `lint.yml` workflow

I tried using a different token in https://github.com/fmtlib/fmt/commit/ccea338070c795fd966a4dc08b19268b6fbad5ef. Could you check if it helped?

the GITHUB_TOKEN does not have write permission when running `lint.yml` workflow

Thanks for testing. Here's a relevant thread that found but didn't have a chance to look in detail yet: https://github.com/actions/checkout/issues/298.