Victor Zverovich
Victor Zverovich
cc @jk-jeon in case you find this interesting
@xjb714 could you submit a PR to add your algorithm to https://github.com/fmtlib/dtoa-benchmark?
@xjb714, thank you!
I've merged https://github.com/fmtlib/dtoa-benchmark/pull/4 and the results look very promising. One question regarding > double requires strict mathematical proof and has passed the random number test Does it mean that the...
@xjb714, I've started looking at the paper and I think the $\frac{3}{4}$ factor should be under logarithm in equation (10), i.e. it should be $\lg(\frac{3}{4} \cdot 2^q)$, not $\frac{3}{4} \cdot...
Great, thank you! I do see my comment addressed in the new revision.
@xjb714, would you be willing to contribute your implementation under the {fmt} license? If yes then we can add it as an option (behind a configuration flag) in {fmt} especially...
Related discussion: https://github.com/jk-jeon/dragonbox/issues/73
BTW if the algorithm is based on @ibireme's `yy_double` which seems to be the case according to https://github.com/ibireme/yyjson/issues/237, I think it should be acknowledged in the paper and the differences...
Not sure about the perf but this cast is also a UB. The portable way to do this without UB is to use `memcpy` which should be optimized similarly.