Victor Zverovich

Results 199 comments of Victor Zverovich

I've removed the commenting for now (https://github.com/fmtlib/fmt/commit/42d3d703b580d11732267b7ea6b6b18ba0802c7b) since it doesn't seem worth spending more time on figuring out how to make it work with github's permissions but thanks anyway.

Closing since it doesn't reproduce on trunk and there are no plans for more 10.x releases but thanks for reporting.

Thanks for the repro, @jagoly, now I see the problem. The fix would be to move this formatter https://github.com/fmtlib/fmt/blob/b61c8c3d23b7e6fdf9d44593877dba1c8a291be1/include/fmt/format.h#L3970-L3971 to `fmt/base.h`. A PR would be welcome.

> It seems simply moving that over isn't enough ... You are right. Unfortunately doing this for user-defined types would be unsafe and lifetime extension won't apply. In any case,...

> Not sure if there's a way to get sign from the nested formatter? No, you'll need to parse it in the `complex` formatter.

@tesch1, do you plan to work on this in the nearest future? If not I will close the PR for now.

It goes without saying that you are always welcome to open a new PR or reopen this one.

All of NEGATIVE_RETURNS look like false positives because the return type of `to_unsigned` is unsigned: https://github.com/fmtlib/fmt/blob/18a9676d958a861a24fbebbaceb1c6863394ab3c/include/fmt/base.h#L433 You might want to report an issue to Coverity since it's clearly broken on...

UNCAUGHT_EXCEPT is also a false positive - `try_resize` doesn't throw when the argument is zero.

BAD_SHIFT are also false positive that contradict the asserts. This leaves the following 3 reports: ``` ** CID 434544: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 434544: Memory - corruptions...