Victor Zverovich comments

Results 199 comments of


                                            Victor Zverovich

Default floating-point formatting does not produce shortest outputs; mismatch with `std::format`

`fmt::format` is modeled after Python's `str.format` where shortest refers to the precision, not the full output. `std::format` diverged a bit because it was specified in terms of `to_chars`.

Default floating-point formatting does not produce shortest outputs; mismatch with `std::format`

I am open to PRs to address this backed by more analysis of the effects of the change and concrete examples.

Default floating-point formatting does not produce shortest outputs; mismatch with `std::format`

This is unrelated and I am surprised that `to_chars` produces "garbage" digits in this case.

Default floating-point formatting does not produce shortest outputs; mismatch with `std::format`

That's the term they used in Grisu paper. You can control precision, so there is no issue here.

`format_as` fails when called with certain `std::views`

There is a simpler repro for the `set_debug_format` error in https://github.com/fmtlib/fmt/issues/3763#issue-2048061455.

`format_as` fails when called with certain `std::views`

Let's keep this one open for tracking the issue.

`format_as` fails when called with certain `std::views`

The `set_debug_format` issue is fixed in https://github.com/fmtlib/fmt/commit/3eb3aef5753b91d689b496a629b9dc5c4a7cd348 but looks like there is another problem.

`format_as` fails when called with certain `std::views`

The original repro compiles now: https://godbolt.org/z/ahh86ME13. Thanks @Arghnews for the fix!

fmt/ranges.h incompatible with Eigen 3.4

`FMT_DEPRECATED_OSTREAM` has been removed so this conflict won't happen on the current version. You can format objects via ostream as follows: ```c++ fmt::print("{}\n", fmt::streamed(m)); ``` In this case Eigen providing...

fmt/ranges.h incompatible with Eigen 3.4

I think you are right and we should improve the begin/end check. Could you submit a PR with your proposed fix?