Victor Zverovich

icon indicating a website link https://vitaut.net icon indicating an email [email protected]

icon company Meta icon location Laniakea Supercluster icon location 🤍❤️🤍 Carbon-based open sourcerer, author of {fmt}, C++20 std::format and C++23 std::print

Results 199 comments of Victor Zverovich

Difference in performance between the default and explicit presentation specifiers in format string compilation

Closing as it doesn't seem to be worth optimizing redundant specifiers.

Formatting `year_month_day` does not work on clang 18.1.0 or earlier, on GCC 13.3 and earlier

We check `__cpp_lib_chrono` which is technically correct but a PR to enable the use of these chrono types more widely would be welcome.

Formatting `year_month_day` does not work on clang 18.1.0 or earlier, on GCC 13.3 and earlier

Closing as there doesn't seem to be much interest in this but a PR would still be welcome.

Should `std::error_code::message` respect the locale set by the user?

The standard is unclear what encoding `error_category::what` should use - I've filed an LWG issue about it: https://cplusplus.github.io/LWG/issue4156. The current proposed resolution there is a bit of a strawman and...

Should `std::error_code::message` respect the locale set by the user?

FYI SG16 just voted in favor of specifying that the string returned by `error_category::what()` is in the C locale (aka execution) encoding as part of [P3395](https://isocpp.org/files/papers/P3395R1.html). The `formatter` specialization for...

Building fails with "error: lvalue required as increment operand"

Please provide an actual godbolt link.

-Wmaybe-uninitialized with GCC 13 and more than 15x fmt::arg

Thanks for reporting. {fmt} tries to be warning-clean on `-Wextra` so yes, we should fix those. If you have a workaround a PR would be welcome.

-Wmaybe-uninitialized with GCC 13 and more than 15x fmt::arg

> You think the fix would be like the initializer I wrote in that PR where I used const and triggered a similar warning? It's possible that the same workaround...

Improve diagnostic to suggest fmt/ranges.h

I think we could check if the type has `begin` / `end` and provide a better diagnostic in that case.

Improve diagnostic to suggest fmt/ranges.h

Thinking more of it, this seems like a bad idea because it would create a weird special case for ranges which is only one of many standard formatters. It is...