Victor Zverovich

icon indicating a website link https://vitaut.net icon indicating an email [email protected]

icon company Meta icon location Laniakea Supercluster icon location 🤍❤️🤍 Carbon-based open sourcerer, author of {fmt}, C++20 std::format and C++23 std::print

Results 199 comments of Victor Zverovich

Add support for `__float128` or `std::float128_t`

If you do it in your own private project then it's less of a problem as you are the only one who will suffer because of the breakage.

fmt::join doesn't handle move-only iterators

~~Fixed by #3800 (thanks).~~

fmt::join doesn't handle move-only iterators

Or is it unrelated?

fmt::join doesn't handle move-only iterators

> It seems like we need to take the join_view argument to format() by mutable & rather than const&, but making this change results in fmt considering join_view to be...

fmt::join doesn't handle move-only iterators

Looks like we need to propagate (lack of) constness during format string compilation. Currently it passes everything by `const&`.

fmt::join doesn't handle move-only iterators

Fixed by #3946.

Performance compare with native dragonbox::to_chars

It is expected that the (default) runtime formatting will be slightly slower than calling Dragonbox directly because the formatting function has to do some extra work. This overhead can be...

Performance compare with native dragonbox::to_chars

Will need to look in more details but one surprising thing is that full and compact cache results are identical.

Performance compare with native dragonbox::to_chars

So I looked in more details and one obvious problem with the new benchmark is ODR violation: you are trying to use {fmt} compiled with different configurations in different TUs....

Performance compare with native dragonbox::to_chars

Looking at the CPU profile ~40% of time is spent postprocessing and writing the output in `do_write_float`: Some of that is inevitable since we have to deal with all the...