facebook
feat: support pyodide on bypass fcntl call
For fbthrift python on jupyterlite/pyodide, fcntl is not yet supported , it's worth bypassing it in such cases similar to the Windows case.
Hi @wey-gu!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@wey-gu, sorry for slow reply. I wonder why is this not covered by the fcntl is None check above?
@wey-gu, sorry for slow reply. I wonder why is this not covered by the
fcntl is Nonecheck above?
Dear @vitaut
Thanks for the reply!
It's due to fcntl can be imported in such case(thus it's actually not None) just it failed later with exception:
module 'fcntl' has no attribute 'fcntl'
Can we make it more generic with something like hasattr instead of checking the platform?