Shane Loretz

Results 302 comments of Shane Loretz

Hi @juancamilog. Those sound like useful additions. I recommend starting a thread at https://discourse.ros.org/c/robot-description-formats One thing to keep in mind is joint types with multiple degrees of freedom are difficult...

> where does the missing urdf_parser_plugin come from? It comes from the `ros2/urdf` repository. https://github.com/ros2/urdf . It's available in ROS Galactic or ROS Rolling. https://index.ros.org has a search bar for...

@eacousineau Thanks for the pull request! Unfortunately I think the earliest we'll be able to review this is after the Crystal release in December. How soon would you like to...

I think this (and #563, #564) might be low-risk enough to warrant merging with just the PR job passing. @ahcorde @clalancette thoughts?

> @sloretz would you mind if I looked into doing this? @allenh1 please do, and thank you!

CI (build: ` --packages-above-and-dependencies tf2_ros` test: `--packages-above tf2_ros`) * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17020)](http://ci.ros2.org/job/ci_linux/17020/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11580)](http://ci.ros2.org/job/ci_linux-aarch64/11580/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17437)](http://ci.ros2.org/job/ci_windows/17437/)

@Myzhar I'm not sure the issue you described is related to this ticket. Would you mind posting it as a new issue on https://github.com/ros2/rviz instead?

This is interesting. I can't predict if it will pass the `test_communication` tests. I recommend adding another test to test_interface_files with `"ハローワールド"` to see what it does when given a...

Foxy CI (build: `--packages-above-and-dependencies rosidl_cmake` test: `--packages-above rosidl_cmake`) * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16953)](http://ci.ros2.org/job/ci_linux/16953/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11517)](http://ci.ros2.org/job/ci_linux-aarch64/11517/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17351)](http://ci.ros2.org/job/ci_windows/17351/)

Hmm, windows has a lot of failures on both Foxy and Galactic. Here's a run without this PR to see if it's an existing issue. Foxy without this PR on...