Shane Loretz

Results 343 comments of Shane Loretz

> Probably, the issue is coming due to latin-1 encoding which is merged as part of this commit I'm not sure about that. It seems to be the right encoding...

It looks like the headers didn't get renamed https://github.com/ros2/rosidl/pull/442#issuecomment-594139770 to get a PR in without making too many changes.

> @sloretz when you get a chance can you take a look and provide any thoughts on how to find the include path from non-CMake systems? Sure, but I think...

> The way it was done before CMake et al: providing include directories and lib paths. Does Unreal Build Tool have helper functions for figuring out where include directories and...

The node-name prefix handling assumes node names are unique (edit: that is, not including the namespace) within a process before remapping.

> To clarify your statement: the remapping process is assuming there is only one talker in the process, in any namespace, and it is not possible to address them individually,...

Tagged as `backlog` as this idea seems a lot more complicated than I was expecting and needs more thought

I think this is the cause of the test failures in CI for https://github.com/ros/joint_state_publisher/pull/67

> @sloretz consider waiting for and asserting the exit code in a pre-shutdown test. > @clalancette @sloretz let me know what you want to do about this ticket. Perhaps some...

Full CI with build type None * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=14973)](http://ci.ros2.org/job/ci_linux/14973/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=9714)](http://ci.ros2.org/job/ci_linux-aarch64/9714/) * macOS [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_osx&build=12653)](http://ci.ros2.org/job/ci_osx/12653/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=15137)](http://ci.ros2.org/job/ci_windows/15137/) Full CI with build type Release * Linux...