Shane Loretz

Results 343 comments of Shane Loretz

Pulls: ros2/rclpy#1338 Gist: https://gist.githubusercontent.com/sloretz/26afab0411e269cd97f9c479b0507b67/raw/0cc08b8cc6fe2a9191ebc2969ec1ba7b33589bc5/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14474 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=21744)](http://ci.ros2.org/job/ci_linux/21744/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16018)](http://ci.ros2.org/job/ci_linux-aarch64/16018/) * Linux-rhel...

@InvincibleRMC Mind fixing the conflict in this one?

This one got talked about today 🧇 . It seems strange that this particular error would only happen occasionally. Does it ever happen after you've run `sudo apt-get dist-upgrade`?

Thank you for the PR! Unfortunately I don't think we should merge this one. [ROS Noetic will reach end-of-life on May 31st, 2025](https://discourse.ros.org/t/ros-noetic-end-of-life-may-31-2025/43160). Every change comes with a risk of...

Thank you for the PR! Unfortunately I don't think we should merge this one. Given the size of the changes, and the removal of `catkin_find_google_test_source`, I think the risk of...

@ros-pull-request-builder retest this please

It looks like this PR is blocked on an issue in rmw_fastrtps https://github.com/ros2/rcutils/pull/460#issuecomment-2088500385 Assigning @ahcorde to look into it post-Jazzy 🧇

Adding the `package.xml` to this repository seems fine to me. It's currently added via a patch during `bloom-release` when releases are made. https://github.com/ros2-gbp/urdfdom_headers-release/blob/master/ros2/package.xml

@ros-pull-request-builder retest this please

Thank you for the PR! > @sloretz you came up in the last working group meeting as the most qualified maintainer to review this PR. Would you be willing to...