Shane Loretz

icon indicating an email [email protected]

icon company Intrinsic icon location Mountain View, CA

Results 343 comments of Shane Loretz

Add types to rosidl_generator_type_description

Pulls: https://github.com/ros2/rosidl/pull/840 Gist: https://gist.githubusercontent.com/sloretz/13781260df9fccdc88ea2c6d6203814d/raw/c529bf3fe304c49d309abcaf327f7ea50f1637e8/ros2.repos BUILD args: --packages-above-and-dependencies rosidl_generator_tests rosidl_generator_type_description TEST args: --packages-above rosidl_generator_tests rosidl_generator_type_description ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14958 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=22271)](http://ci.ros2.org/job/ci_linux/22271/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16532)](http://ci.ros2.org/job/ci_linux-aarch64/16532/)...

Incompatibility with nested action client/servers

The PR is a good change, but all `spin` functions including `spin_until_future_complete` aren't intended to be used within a callback. Use coroutines instead. Define the callback with `async def` and...

event_handler.py types

@InvincibleRMC Mind fixing the conflict in this one?

event_handler.py types

@mergifyio update

event_handler.py types

Pulls: https://github.com/ros2/rclpy/pull/1340 Gist: https://gist.githubusercontent.com/sloretz/8a6a47f73b82a540c33cfd8f6c146c1c/raw/cad8313791c21aafe30936b91b18b9a7a77e6544/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15027 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=22343)](http://ci.ros2.org/job/ci_linux/22343/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16606)](http://ci.ros2.org/job/ci_linux-aarch64/16606/) * Linux-rhel...

event_handler.py types

Thank you for the PR!

Update Service and Action Protocols

Pulls: https://github.com/ros2/rclpy/pull/1409 Gist: https://gist.githubusercontent.com/sloretz/eda8121c18ea624ad57479c247fe36c5/raw/19c077765cb1e44749aed94d4b65b20df0b6222d/ros2.repos BUILD args: --packages-up-to rclpy TEST args: --packages-select rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15259 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=22606)](http://ci.ros2.org/job/ci_linux/22606/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16848)](http://ci.ros2.org/job/ci_linux-aarch64/16848/) * Linux-rhel...

Update Service and Action Protocols

Thank you for the pr!

Adds types to Lifecycle Objects

@mergifyio update

Adds types to Lifecycle Objects

Pulls: ros2/rclpy#1338 Gist: https://gist.githubusercontent.com/sloretz/5ae8c9493cbb2f6cd304e97a2d4ef14c/raw/0cc08b8cc6fe2a9191ebc2969ec1ba7b33589bc5/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14473 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=21743)](http://ci.ros2.org/job/ci_linux/21743/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16017)](http://ci.ros2.org/job/ci_linux-aarch64/16017/) * Linux-rhel...