Shane Loretz

Results 302 comments of Shane Loretz

Foxy CI re-run * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17002)](http://ci.ros2.org/job/ci_linux/17002/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11563)](http://ci.ros2.org/job/ci_linux-aarch64/11563/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17411)](http://ci.ros2.org/job/ci_windows/17411/)

Foxy Windows without this PR for comparison: Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17441)](http://ci.ros2.org/job/ci_windows/17441/)

Thanks for the issue! Since Galactic is EOL I'll close this for now. If it continues to happen on a more recent version then we can reopen this.

> I'm not quite sure how enum support should look like in .idl file. Especially I see that in ROSIDL one should place constants under special module _Constants The constants...

> [ad-hoc parser implementation](https://github.com/ros2/rosidl/blob/bdcaddd542fb15b46c2e235c601f4a87a10ed3a5/rosidl_parser/rosidl_parser/parser.py#L92). I guess it was enough at the time and due to very narrow feature set. @r7vme A small improvement here would be docstrings on the functions....

> To make sure I understand, is this because third-party generators are not present in our core builds and so core interfaces are not generated for these other languages? That's...

> the CMake build logic itself What do you mean by build logic? I thought most of the non-reusable stuff was the ament extension boilerplate, defining the output files from...

I'm able to reproduce this using the most recent `Foxy` binaries Foxy rosidl packages installed ``` ros-foxy-rosidl-adapter/focal,now 1.2.1-1focal.20210423.001432 amd64 [installed] ros-foxy-rosidl-cmake/focal,now 1.2.1-1focal.20210423.001729 amd64 [installed] ros-foxy-rosidl-default-generators/focal,now 1.0.1-1focal.20210630.223214 amd64 [installed,automatic] ros-foxy-rosidl-default-runtime/focal,now 1.0.1-1focal.20210630.223215...

I'm also able to reproduce on `master` branches, so this is probably an issue in ROS Galactic and ROS Rolling too.

Looks like an encoding issue in the generated idl file, the problem is probably somewhere in `rosidl_adapter` ```idl // generated from rosidl_adapter/resource/msg.idl.em // with input from wstr_msg/msg/WstrTest.msg // generated code...