rosidl icon indicating copy to clipboard operation
rosidl copied to clipboard

Use target output name for exporting typesupport library (backport #625)

Open mergify[bot] opened this issue 3 years ago • 6 comments

This is an automatic backport of pull request #625 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

mergify[bot] avatar Dec 06 '21 19:12 mergify[bot]

Full Foxy CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

hidmic avatar Feb 08 '22 15:02 hidmic

Foxy CI (build: --packages-above-and-dependencies rosidl_cmake test: --packages-above rosidl_cmake)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

sloretz avatar Jul 12 '22 18:07 sloretz

Hmm, windows has a lot of failures on both Foxy and Galactic. Here's a run without this PR to see if it's an existing issue.

Foxy without this PR on windows (build: --packages-above-and-dependencies rosidl_cmake test: --packages-above rosidl_cmake) Build Status

sloretz avatar Jul 12 '22 23:07 sloretz

Foxy CI re-run

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

sloretz avatar Jul 19 '22 17:07 sloretz

Foxy Windows without this PR for comparison: Windows Build Status

sloretz avatar Jul 25 '22 22:07 sloretz

Any chance we could get this merged? I had to disable tests on some packages I support because of this issue.

danthony06 avatar Oct 10 '22 16:10 danthony06

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

quarkytale avatar May 11 '23 21:05 quarkytale

Windows for comparison: Build Status

quarkytale avatar May 15 '23 17:05 quarkytale

Retry Windows for comparison: Build Status

quarkytale avatar May 15 '23 21:05 quarkytale

Same flaky tests failed on Windows, getting this in

quarkytale avatar May 17 '23 05:05 quarkytale