Shane Loretz comments

Results 315 comments of


                                            Shane Loretz

Prototype code for seeing if FindPython3 is usable for rosidl_python

Full CI with build type None * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=14983)](http://ci.ros2.org/job/ci_linux/14983/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=9724)](http://ci.ros2.org/job/ci_linux-aarch64/9724/) * macOS [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_osx&build=12669)](http://ci.ros2.org/job/ci_osx/12669/) (Edit: issue with buildfarm machine, failed to delete workspace) * Windows [![Build...

Fix numpy include dirs

The change looks reasonable except that I couldn't figure out if `Python3_EXECUTABLE` will map to the Debug python executable when appropriate. I kicked off a Windows Debug build to check:...

Fix numpy include dirs

Yeah, setting the debug interpreter directly seems reasonable. There is [logic for finding the Python debug executable in a find module provided by `python_cmake_module`](https://github.com/ros2/python_cmake_module/blob/754c80a0f67d2fbbb7c92d36e03401f0eb26a885/cmake/Modules/FindPythonExtra.cmake#L134-L150). It looks like this package already...

Fix int32[] and uint32[] 32 bit sequence types only accepting 16 bit sequences

Full CI to see if fixing the types breaks anything downstream * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=14678)](http://ci.ros2.org/job/ci_linux/14678/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=9430)](http://ci.ros2.org/job/ci_linux-aarch64/9430/) * macOS [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_osx&build=12343)](http://ci.ros2.org/job/ci_osx/12343/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=14821)](http://ci.ros2.org/job/ci_windows/14821/)

`check_multiple_nodes_launch_test` test flaky on Windows

I'm unable to reproduce this issue on Windows.

[WiP] Package whitelist resp. blacklist

Is the goal a feature that ignores ROS packages at compile time? If so, I would recommend a user interface of a CMake variable specified on the command line. When...

create publisher even without subscriber

Is this ticket for just publishers? Does it also apply to subscribers? If a subscriber exists on side A should a subscription be created on side B for the purpose...

test_record, test_record_regex, test_record_all are flaky

> Also potentially test_play [Another example](https://ci.ros2.org/job/nightly_linux_repeated/2416) of `test_play` being flaky on Ubuntu Focal with FastDDS The test timed out while running `RosBag2PlayTestFixture.recorded_messages_are_played_for_filtered_topics` ``` projectroot.test_play__rmw_fastrtps_cpp rosbag2_transport.test_play__rmw_fastrtps_cpp.gtest.missing_result ``` Console output ``` Start...

Add benchmark tests

> Do we have any plan to integrate this kind of benchmark in CI/CD so that it can detect the performance degression? There are benchmark jobs run for each release...

Add benchmark tests

@ros-pull-request-builder retest this please