Jason Young

Results 217 comments of Jason Young

Parking this for similar reasons as #2347. Wind resistance will be part of the drivetrain torque calculation. However, we can go ahead and bring in the pitch compensation piece since...

I spent a little time looking into this one. There are three basic issues: - [ ] Ignore path wildcard expansion changed somehow, but it's easy to fix - [...

> I spent a little time looking into this one. There are three basic issues: I made a separate PR #2925 with my proposed fixes, so the bot wouldn't force-push...

I checked the device you were using when you opened this PR. All the routes uploaded today on stock openpilot recognized your car. Can you provide a specific route and...

We really need an uploaded route or at least a dongle ID to look into this.

Several conversations here, most of which are old and possibly no longer applicable. Let's try to disentangle: * Dongle ID `81a6ddf7edcd84f4` from @cloudran seems active but isn't uploading current logs....

> `grey means engaged with human overriding` > the above UI makes sense right? Technically yes, but that statement doesn't really account for the vehicle being outside its control envelope....

> [@jyoung8607](https://github.com/jyoung8607) do you have a suspected fix or is the cause unknown? Cause is understood to be stock LKAS forcing a stock ACC disengagement due to lack of driver...

Did you have always-on DM enabled? If so, is this still an issue after #35834?

Thank you for the PR! At a glance it looks good, except we do need a CI test route. Can you share a route that you don't mind making public,...