opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Honda: Bosch - longitudinal tuning

Open mvl-boston opened this issue 7 months ago • 1 comments

Honda Bosch A and Bosch C control acceleration based on gas pedal input. The acceleration from this pedal force can be impacted by environmental factors like hills and wind drag, so logic below is needed to offset this.

Note that brake is commanded by an acceleration input and does not need these adjustments. In addition, on radarless cars, both gas and brake are controlled by acceleration inputs and therefore also do not need these adjustments.

In my test routes below, this tuning results in a massive reduction in disengagements.

  1. Implemented missing aspects of Honda Nidec tuning into Honda Bosch:
  • Wind drag compensation (roadtest found Nidec wasn't m/s2, so new math here)
  1. added downhill braking fix - see details here

Notes:

  • This is also confirmed to help Nidec - will add to a separate Nidec tuning pr once I finish tuning and testing it.
  • This is baselined on gas-only PID to allow this logic to only impact gas, therefore this PR is baselined on pr2347 (replacement for pr2179), .

New test route after rebaselining to pr2347:

  • 9662a1dab70c9dc3/000000a6--a546f757e5

Before/after routes on prior: 2179 baseline

  • before: ad9840558640c31d/00000009--a0348fcf09
  • after: ad9840558640c31d/00000011--b2de78f396
  • after hillbrake: ad9840558640c31d/00000008--aeaa9f13d2

mvl-boston avatar Apr 29 '25 13:04 mvl-boston

Parking this for similar reasons as #2347. Wind resistance will be part of the drivetrain torque calculation. However, we can go ahead and bring in the pitch compensation piece since that offsets acceleration.

jyoung8607 avatar Sep 09 '25 19:09 jyoung8607