Jason Young
Jason Young
@mvl-boston I'll have to look closer at the situation with speed signals. But if we can get a dashcam route with LKA activation to check actuator range, we'll be able...
Dashcam route: `f9bcb4642e893c8b/0000004b--111f3ad96c` Verified the actuator range is the usual 2560.
I agree that ENGINE_DATA.XMISSION_SPEED is missing on Integra. However, checking a broad sample of other cars, CAR_SPEED.CAR_SPEED seems widely available. If the speed data we get from CAR_SPEED is good...
In order to look into this, we'll need you to share a route ID with uploaded logs.
> We're not really interested in merging support for cars that don't have a path to being upstreamed. Can we reserve judgment on that for now? This PR looks like...
Marking draft for the same reasons described in #2347.
- [ ] See if BRAKE_ERROR can be made global/common, it's present in a Nidec DBC as well - [ ] #2638 - [ ] Drive testing - [ ]...
> 1. Does comma3+red panda usage require bus 4 as written? That's not necessary, each Panda only knows about what it's hooked up to. > 2. This makes startup faults...
> * [ ] Why does it fault on quick restarts? This *could* be connected to #2632. Not saying it is for sure, but Panda is dealing with a disruption...
Per our discussion, I'd like to try PIF control with drivetrain torque as the feedforward rather than acceleration. Keeping this open but marking as draft, since it's now Plan B.