Jason Young
Jason Young
I'm reasonably happy with the state of the code, except I wish I knew a better label than ALT_ACCS, I don't know enough about the underlying GM architecture to name...
Resolution of commaai/agnos-builder#423 may resolve this as well.
We need this route uploaded to the CI bucket: `6a3e5d31bf499cfe/0000000b--a48d1b4e42`
Searched for overlaps with commaai/openpilot#34771. Annoyingly, 0x3C0 is present on a few Chrysler and HKG segments, so this will need to be wrapped in CRC/counter validation per the discussion in...
Additional case in `e4378b4a6431a261/00000005--8433f872e5` All of these reports are for strong driver overrides at sharp angles. There's probably an angle or rate threshold we're violating.
> To be precise, this is not the kind of vibration/rumbling that Hondas give the driver to indicate a warning (like lane departure), but almost feels as if I am...
The [2020 Honda CR-V owner's manual](https://cdn.dealereprocess.org/cdn/servicemanuals/honda/2020-crv.pdf) shows three causes of tactile warnings: * Lane Keeping Assist System * Road Departure Mitigation * Driver Attention Monitor For LKAS and RDM, I'm...
> We're operating your EPS well below its documented speed support, so by definition we can encounter undocumented behavior. There could be some sort of low speed driver takeover warning...
This was reopened because the change in #2570, while valid and appropriate, doesn't actually prevent openpilot from trying to steer. Correctly fixing this will require actual minSteerSpeed handling in the...
Just to set expectations, I'm down with merging this if the data look good, but it's going to take a while to evaluate. I would have expected this to make...