opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

[bot] Update cppcheck to 2.18.0

Open github-actions[bot] opened this issue 5 months ago • 1 comments

See all cppcheck releases: https://github.com/danmar/cppcheck/releases

github-actions[bot] avatar Jul 25 '25 22:07 github-actions[bot]

@maxime-desroches can you make sure to get these cppcheck bumps through?

adeebshihadeh avatar Sep 01 '25 17:09 adeebshihadeh

I spent a little time looking into this one. There are three basic issues:

  • [ ] Ignore path wildcard expansion changed somehow, but it's easy to fix
  • [ ] Apparently valid 17.3 violations for microsecond_timer_get(), needs some cleanup
  • [ ] typeof usages are throwing false 17.3 violations after danmar/cppcheck#7327
    • [ ] SAFETY_[ABS/MIN/MAX/CLAMP], tried several things, will probably just have to ignore
    • [ ] GET_FLAG, can just cleanup params to always use uint16_t

jyoung8607 avatar Dec 01 '25 19:12 jyoung8607

I spent a little time looking into this one. There are three basic issues:

I made a separate PR #2925 with my proposed fixes, so the bot wouldn't force-push them into oblivion if review takes awhile. It includes an additional minor version bump 2.18.0 -> 2.18.3.

jyoung8607 avatar Dec 02 '25 00:12 jyoung8607