Jason Young

Results 217 comments of Jason Young

Sounds like you're working on something interesting. In case it helps you, I found out very recently there's documentation on this algorithm. See the [AUTOSAR E2E Protocol Specification](https://www.autosar.org/fileadmin/standards/R20-11/FO/AUTOSAR_PRS_E2EProtocol.pdf), specifically Profile...

That looks good! To make this easy for the openpilot team to review, I suggest splitting this into three PRs. Phase 1: Add tests for the currently existing messages, make...

@JaCzekanski I'm still interested in these changes, if you're still interested in working on them. If you've moved on, eventually I'll pick this up and finish it. Moving to Draft...

Looks pretty good just reading it over, though I want to play with it locally just to make sure it fails where I think it'll fail. I'd still like to...

@JaCzekanski here's sample messages for 0x187 EV_Gearshift: 180.611 | 0x187 | 0 | 0x70801500000000F0 -- | -- | -- | -- 180.711 | 0x187 | 0 | 0x07811500000000F0 180.811 |...

@JaCzekanski Thanks for the other two PRs, you're good to update this PR with your new messages!

Null-effect since openpilot doesn't make active use of these messages, but validated anyway: * CI testing with `test_checksums.py`, all checks pass * Local testing with `pytest selfdrive/car/tests`, all checks pass...

@JaCzekanski Happened to look this over again, and ESP_33 support snuck in without test data. Can you file another PR adding test data for ESP_33? Long term I'd like to...

Closing this PR due to age, conflicts, and too many changes to effectively review. @V8Joel We would be open to a standalone PR that makes the minimum set of repairs...

Panda needs a corresponding change, it's also only checking 12 bits wide: https://github.com/commaai/panda/blob/9aec4294cc940964a5b2fa34aa83301ab408b377/board/safety/safety_gm.h#L137 I'm not super stoked the "over-actuation" from people test driving this gets through Panda safety checks. I'm...