Jon Atack
Jon Atack
> I like the simplified interface, having to write something like `LogPrintLevel(BCLog::NET, BCLog::Level::Error, ...)` for each log would be annoying For the severity level logging, I'd prefer to have a...
> forcing usage of a single `Log` function That doesn't make sense if the goal, like the title of this PR, is to simplify the API. One macro is simpler,...
Post-merge ACK 74ebd4d1359edce82a134dfcd3da9840f8d206e2
Concept ACK, though I'm unable to reproduce this on macOS, which makes sense per `src/common/system.cpp#L66-73`: ```cpp // On most POSIX systems (e.g. Linux, but not BSD) the environment's locale //...
In commit 0ac5cf9141441ea539d2f345d0d516d24a2f77bd ``` $ ./src/test/test_bitcoin -t transaction_tests Running 7 test cases... test/transaction_tests.cpp:192: error: in "transaction_tests/tx_valid": mapFlagNames is missing a script verification flag ``` Edit: 4371ffefef2 two commits later appears...
The behavior was intended to be added in https://github.com/bitcoin/bitcoin/pull/11191. I downloaded and tested v23.1 and the behavior wasn't functional: passing `0` or `none` had no effect. In v24, f1379aeca9d3a8c4d3528de4d0af8298cb42fee4 made...
Rebased. > could take advantage of that, to remove some of the complexity here; do we definitely need multiple different ways of achieving the same logging toggling? Exploring this, it...
Rebased following merge of #27632; only change is to commit 4351f26203c6daab321d478a3992e1723cc60814 per `git range-diff ee22ca5 5991edd 630b38e`.
Thank you @pinheadmz and @ajtowns for the review; updated commit 0c6c39056851d13c0ca3cea227fac72a4338bed0 per https://github.com/bitcoin/bitcoin/pull/27231#discussion_r1239861077. git diff 630b38e 08a367c ```diff --- a/src/init/common.cpp +++ b/src/init/common.cpp @@ -11,7 +11,6 @@ #include #include #include -#include...