Jon Atack comments

Results 455 comments of


                                            Jon Atack

refactor: move index class members from protected to private

@PastaPastaPasta and @RandyMcMillan, would you mind re-ACKing here?

refactor: move index class members from protected to private

Rebased (see `git range-diff dabec990 cff04a7 4fdd404`) and added 4fdd404e652ca6443f666c05341ccb775f461350 left over from an [unintentional reverted change](https://github.com/bitcoin/bitcoin/pull/21726#discussion_r860950350) in #21726. @PastaPastaPasta, @RandyMcMillan and @brunoerg, mind re-ACKing? Thanks :heart:

refactor: move index class members from protected to private

Updated the motivation in the PR description and simplified the last commit by dropping the class-to-struct change, per `git diff f5e985b 3f26a36` ```diff --- a/src/index/base.h +++ b/src/index/base.h @@ -57,8 +57,9...

refactor: move index class members from protected to private

> Are you still working on this? Yes. Might be useful to re-open rather than opening a new one, as there is discussion and some feedback to address.

refactor: move index class members from protected to private

Closing temporarily so that I can re-open it -- am still interested to work on this.

During IBD, prune as much as possible until we get close to where we will eventually keep blocks

Interesting, will have a look.

During IBD, prune as much as possible until we get close to where we will eventually keep blocks

Concept ACK

blockstorage: do not flush block to disk if it is already there

@pinheadmz Thanks for working on unit test coverage -- will circle back soon.

fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses

Concept ACK. Reviewed prerequisite PR #27071.

wallet: Add CoinGrinder coin selection algorithm

Concept ACK here or https://github.com/bitcoin/bitcoin/pull/28977 based on today's IRC discussion https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2023-11-30#986727.