Jon Atack

Results 159 comments of Jon Atack

Thanks @achow101, I need to review and test this.

``` $ ./test/lint/lint-python.py test/functional/feature_package_rbf.py:18:1: F401 'test_framework.util.assert_equal' imported but unused ```

ACK 32953718a3fb8e2f298b99e1a2ee72af1ea5be8c edit: modulo removing the `GCSFilterDecodeSkipCheck()` benchmark as pointed out below

Looks like ae7ae36d311a869b3bda41 added a new check to the Clang-tidy CI (unrelated to changes in the last push) that is red now: ``` /src/test/fuzz/blockfilter.cpp:34:25: error: the const qualified variable 'gcs_filter'...

Diff-only review re-ACK 07fdd10ca1d0bd2bc1d2756f1bc2c069ae97c45a per `git diff 1204e3d 07fdd10`

@tehelsper Your issue reminded me of a similar one I am seeing -> #24816.

Updated with review feedack by @klementtan (thanks!) per `git range-diff 0897b18 5326f46 706805d`

Updated to address @fjahr's https://github.com/bitcoin/bitcoin/pull/25614#pullrequestreview-1064438055 suggestion in the -loglevel help with `"Set the global or per-category severity level for logging categories enabled with the -debug configuration option or the logging...

> Since the new log level `Trace` is unused outside of tests, is it assumed that some of the existent `Debug` log messages can/should be converted to `Trace`, or is...

Updated with @vasild's review feedback per `git range-diff a5d5569 63215dd b99dc23` Invalidates ACKs by @1440000bytes, @dunxen, @brunoerg and @jarolrod and previous ACKs by @klementtan and @w0xlt.