Jon Atack

Updated the tests with @luke-jr's review feedback (thanks!) git diff 08a367c 93b387f ```diff --- a/src/test/logging_tests.cpp +++ b/src/test/logging_tests.cpp @@ -262,11 +262,11 @@ BOOST_FIXTURE_TEST_CASE(logging_Conf, LogSetup) BOOST_FIXTURE_TEST_CASE(logging_IsNoneCategory, LogSetup) { - for (const std::string&...

Updated per `git diff 93b387f ce8faad` to address @fanquake's review feedback (thanks!) and replace the comment with clearer code. diff ```diff diff --git a/src/logging.cpp b/src/logging.cpp index f197943a0bd..d3f61ca54c2 100644 --- a/src/logging.cpp...

Updated per `git range-diff 6ce5e8f ce8faad 05143b2` to take review feedback by @ajtowns (thanks!) and rebase for CI.

This seems close, has been reviewed by five reviewers (thanks!) and updated for their feedback. I propose to give this another week for (re-)ACKs and merge. If it hasn't gone...

Updated for @ajtowns' feedback to make `IsNoneCategory()` a static function in [`6f4127b` (#27231)](https://github.com/bitcoin/bitcoin/pull/27231/commits/6f4127be01ad75d3e460cdb9e7d902e99a595fbc). git diff 05143b2 94b059f ```diff diff --git a/src/logging.h b/src/logging.h index 4dfb7106327..83c285c905d 100644 --- a/src/logging.h +++ b/src/logging.h @@...

> Has this comment being replied to anywhere already? Yes, https://github.com/bitcoin/bitcoin/pull/27231#issuecomment-1492195680 and the pull description contains that discussion as well.

I think that question is addressed in the pull description.

> I would have thought it was obvious that I don't see an answer to that question in the pull description, so that's an impressively unconstructive response. It's reasonable to...

I'm going to open an alternate pull that does what you suggest and see what reviewers (if any) prefer.

Will re-open as a new PR, along with the alternative version, as it is a good and mature patch with many updates made for reviews and nits.