Jon Atack
Jon Atack
> needs rebase if still relevant. For the `previous releases` CI? (I don't find any merge conflicts with current master.)
Ah, the second try did it :) build log ``` test/fuzz/process_message_e2e.cpp:59:1: error: a type specifier is required for all declarations FUZZ_TARGET_INIT(process_message_e2e, initialize_process_message_e2e) ^ test/fuzz/process_message_e2e.cpp:59:18: error: use of undeclared identifier 'process_message_e2e'...
Will re-review this soon.
Suggest backporting #29200 that resolves https://github.com/bitcoin/bitcoin/issues/29197.
Upgraded to sqlite3 version 3.44.1 `(2023-11-22 14:18:12 d295f48e 64-bit)` on ARM64 macOS 13.6 Ventura. The unit test suite is green for me on v25.1 and current master, both built from...
(FWIW, upgraded sqlite from 3.44.1 to 3.44.2. via homebrew, compiled and ran tests, and v25.1 and master are both green.)
> Addressed [feedback](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) provided by @jonatack regarding first commit [6898219](https://github.com/bitcoin/bitcoin/commit/6898219043f42ae42e4703c549e656f56d276d13). > > Updated second commit [cf7dd35](https://github.com/bitcoin/bitcoin/commit/cf7dd3564a3ace4153a32930f36bd78432b59097) following some directions [given](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1483546926) by @jonatack and [discussed](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1573464319) with @andrewtoth. Thank you -- just...
Concept ACK. I'd find it helpful to also log the addrport if `fLogIPs` is true, along with the network (for instance, because IPv6 addresses look the same as CJDNS ones),...
I'll have a look later today but my initial read, to be confirmed, was Approach NACK in the direction, which I'll detail more on, and that this would hinder progress...
> The first 6 commits apply cleanly on top of it Thanks, will review properly asap.